Review main Ready for review Quiet

96799[TASK] Prepare upload validation options once

Wouter Wolters CR +1 V +1 Normal +198 −19 updated 10/18/26, 11:53

Commit message

Resolve allowed file extensions, file size bounds and escaped size
labels once per validation call and pass them to the per-file checks.
Keep prepared values local so subsequent calls use updated options
and storage defaults.

Preserve error codes, per-file indexes and custom messages. Skip
option preparation for empty collections, and emit decimal-option
deprecations once per option for each non-empty validation call.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/96799/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/96799/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Oliver Klee +1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Wouter Wolters uploaded patch set 1 10/17/26, 16:56

  2. core-ci voted on patch set 1 V +1 10/17/26, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111480

  3. Simon Schaufelberger commented on patch set 1 10/17/26, 18:17

    FileExtensionValidator.php:68 Unresolved

    i would find it cleaner to add a return statement above and then extract this into a single if and bring the nesting one level up
  4. Oliver Klee voted on patch set 1 CR +1 V +1 10/18/26, 09:21

  5. Wouter Wolters uploaded patch set 2 CR +1 V +1 10/18/26, 11:13

  6. core-ci voted on patch set 2 V +1 10/18/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111515

  7. Oliver Klee voted on patch set 2 CR +1 V +1 10/18/26, 11:53