Review main Abandoned

96801[TASK] Align LIMIT expectations of the conformance suite with CONTENT

Alexander Schnitzler CR 0 V 0 Easy +16 −1 updated 10/20/26, 11:19

Commit message

The conformance suite marked "LIMIT is applied in SQL before the
overlay drops rows" as an inconsistency to be fixed. Core's CONTENT
object does the same: select.max cuts in SQL before the language and
workspace overlay drops rows, so fewer rows than the limit can come
back. As the core yardstick for record lists, this is the expected
behaviour, not a bug.

The case is now described as matching CONTENT. A new test pins the
actual deviation: with respectSysLanguage enabled, the SQL already
excludes default rows without a visible translation, so Extbase
returns the full limit, while CONTENT returns fewer rows for the
same data (only P4 for a limit of 2, as P5 with its hidden
translation counts).

This does not change any class under Classes/; it only adjusts
tests.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 1

Review log 23

  1. Alexander Schnitzler uploaded patch set 1 10/17/26, 18:22

  2. core-ci voted on patch set 1 V +1 10/17/26, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111482

  3. Alexander Schnitzler abandoned the change 10/20/26, 11:19

    It treated "LIMIT is applied in SQL before the overlay drops rows" as expected behaviour, because CONTENT's select.max cuts the same way. We concluded the opposite: the goal for Extbase is LIMIT after the overlay, so fewer rows than the limit is a gap to close, not a behaviour to pin. The conformance suite on main reflects that: #96798 keeps the "before overlay" case as a @todo and already contains the respectSysLanguage limit test this change added.