Review main Merged

96803[TASK] Cover changed children of excluded inline fields

Alexander Schnitzler CR +2 V +2 Hard +588 −0 updated 11/06/26, 11:19

Commit message

An inline field with "l10n_mode" => "exclude" gives every translation
its own copy of each child when the parent is localized. Nothing
covered what happens to these copies when a child of the default
record is changed afterwards.

This adds ExcludedFromTranslationWriteDefaultChildTest with the core
and the Extbase side next to each other. A field of the child table
without its own l10n_mode keeps its value in the copy, for DataHandler
and Extbase alike; with "l10n_mode" => "exclude" on the child field,
DataHandler writes the new value to the copies. Covered are language
aware and monoglot child tables, the parent in the data map, two
translations, 1:n relations and workspaces.

Where Extbase differs from core (excluded child field, workspace),
the Extbase test is skipped. Localizing to a second language with
monoglot children is skipped because of a core bug.

This does not change any class under Classes/; it only adds tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 5

Files 13

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 10/17/26, 19:39

  2. core-ci voted on patch set 1 V +1 10/17/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111484

  3. Alexander Schnitzler wrote 10/17/26, 19:47

    Topic set to extbase
  4. Alexander Schnitzler commented on patch set 1 10/17/26, 19:47

    This change is ready for review.
  5. Oliver Klee voted on patch set 1 V +1 10/18/26, 09:21

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/06/26, 09:42

  7. Benni Mack voted on patch set 1 CR +2 V +2 11/06/26, 11:19

  8. Benni Mack merged patch set 2 11/06/26, 11:19