Review main Merged

96816[BUGFIX] Complete partially configured default crop variant

Benni Mack CR +2 V +2 Normal +73 −0 updated 11/10/26, 08:01

Commit message

The image manipulation element drops its built-in "default" crop
variant as soon as any cropVariants configuration is given. Changing
a single option of the default variant, e.g. its selectedRatio via
TCEFORM or overrideChildTca, therefore resulted in a variant without
aspect ratios and the exception 1620147893.

A configured crop variant matching a built-in variant now receives
the missing options from it. Options which are configured explicitly,
such as a custom list of allowed aspect ratios, are kept as they are,
and custom crop variants are not extended with the default variant.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 10/18/26, 13:45

  2. core-ci voted on patch set 1 V +1 10/18/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111525

  3. Benni Mack marked it ready for review 10/18/26, 14:26

  4. Benni Mack rebased onto patch set 2 V +1 10/23/26, 05:17

  5. core-ci voted on patch set 2 V +1 10/23/26, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112209

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/25/26, 21:24

  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/10/26, 07:45

  8. Benni Mack voted on patch set 2 CR +2 V +2 11/10/26, 08:01

  9. Benni Mack merged patch set 3 11/10/26, 08:01