Review main Merged

96827[TASK] Sort local directory entries natively

Wouter Wolters CR +2 V +2 Easy +34 −4 updated 10/19/26, 20:23

Commit message

Use ksort() and krsort() with SORT_NATURAL | SORT_FLAG_CASE instead of
uksort() with a PHP callback invoking strnatcasecmp(). This keeps all
comparisons inside the native sorting implementation.

Preserve sorting keys, case-insensitive ties and ascending or
descending order. Add regression coverage for natural ordering,
numeric keys and duplicate extensions.

A PHP 8.5 benchmark with OPcache enabled measures 36-38% less time for
the complete sorting method. Warm local folder listings take about
3-4% less time with 1,000-10,000 files. Browser requests were not
measured.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Wouter Wolters uploaded patch set 1 10/18/26, 15:27

  2. Wouter Wolters updated the commit message in patch set 2 10/19/26, 19:59

  3. Wouter Wolters marked it ready for review 10/19/26, 19:59

  4. Wouter Wolters wrote 10/19/26, 19:59

    Unset private
  5. core-ci voted on patch set 2 V +1 10/19/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111707

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/19/26, 20:23

  7. Benni Mack merged patch set 3 10/19/26, 20:23