Review main Merged

96842[TASK] Showcase slug post-processing in styleguide

Wouter Wolters CR +2 V +2 Normal +81 −1 updated 11/09/26, 21:05

Commit message

Add a slug post-modifier that prepends /jobs/ to the stored slug.
Reuse the existing source field and regex replacements, and explain
the difference from a display-only prefix. Verify generation and
saving the modified value through DataHandler.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Wouter Wolters uploaded patch set 1 10/18/26, 18:06

  2. Wouter Wolters uploaded patch set 2 10/22/26, 18:49

  3. core-ci voted on patch set 2 V +1 10/22/26, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112175

  4. Wouter Wolters uploaded patch set 3 V +1 10/23/26, 16:03

  5. core-ci voted on patch set 3 V -1 10/23/26, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112356

  6. Wouter Wolters rebased onto patch set 4 V -1 10/24/26, 06:51

  7. core-ci voted on patch set 4 V +1 10/24/26, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112397

  8. Simon Schaufelberger commented on patch set 4 10/24/26, 19:58

    SlugPostModifier.php:21

    this annotation is kind of useless as the whole styleguide is not meant for public usage ;)
  9. Georg Ringer voted on patch set 4 CR +1 V +1 11/09/26, 21:05

  10. Benni Mack commented on patch set 4 CR +2 V +2 11/09/26, 21:05

    SlugPostModifier.php:21 Reply

    Done
  11. Benni Mack merged patch set 5 11/09/26, 21:05