Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96845[!!!][TASK] Move Extbase dirty tracking into the persistence layer
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/96845/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/96845/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 40
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-111136-ExtbaseEntityDirtyTrackingMethodsRemoved.rstnew+323 −0
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php+5 −193
- typo3/sysext/extbase/Classes/DomainObject/DomainObjectInterface.php+1 −14
- typo3/sysext/extbase/Classes/EventListener/ExtbaseHistoryTracker.php+3 −1
- typo3/sysext/extbase/Classes/Persistence/Exception/UnmanagedObjectException.phpnew+24 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+7 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+60 −11
- typo3/sysext/extbase/Classes/Persistence/Generic/CleanStateTracker.php4new+349 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+24 −1
- typo3/sysext/extbase/Classes/Persistence/ObjectMonitoringInterface.phpdeleted+0 −42
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+1 −21
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+4 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerMmTestImport.csvnew+16 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerMmTestResultChildRemoved.csvnew+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerMmTestResultTitleChanged.csvnew+8 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerMmTestResultUnchanged.csvnew+13 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerTestImport.csvnew+12 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerTestResultFormTitle.csvnew+9 −0
Show 20 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerTestResultReloadedChange.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerTestResultScalarChange.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerTestResultUnchanged.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerUnmanagedObjectTestImport.csvnew+19 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CleanStateTrackerUnmanagedObjectTestResultUnchanged.csvnew+16 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/CleanStateTrackerLazyProxyTest.phpnew+89 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/CleanStateTrackerMmRelationTest.phpnew+138 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/CleanStateTrackerTest.phpnew+531 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/CleanStateTrackerUnmanagedObjectTest.phpnew+156 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/IsDirtyTest.php+12 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php+2 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/NonDomainObjectPropertyPersistenceTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php+59 −19
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+27 −12
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+6 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+6 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+1 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+56 −0
Review log 1925
-
Alexander Schnitzler uploaded patch set 1 10/18/26, 20:07
-
core-ci voted on patch set 1 V +1 10/18/26, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111561
-
Alexander Schnitzler marked it ready for review 10/18/26, 20:21
-
Alexander Schnitzler wrote 10/18/26, 20:21
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2
V +110/19/26, 04:59 -
core-ci voted on patch set 2 V +1 10/19/26, 05:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111575
-
Oliver Klee voted on patch set 2 V +1 10/19/26, 17:22
-
Simon Schaufelberger commented on patch set 2 10/20/26, 17:31
CleanStateTracker.php:170"that is simply too much" is not a very clear message imo. Could this improved so that it becomes clearer to understand what is "too much"? I know this message was copied but was not good in the first place. -
Alexander Schnitzler commented on patch set 2 10/20/26, 17:48
CleanStateTracker.php:170ReplyWell, I always took it for a rather comical comment. Not sure if we actually need a better message here but it could be more technical like `The uid of the persisted object of class "%s" was changed from "%s" to "%s". Changing the uid of a persisted object is not supported.` -
Simon Schaufelberger commented on patch set 2 10/20/26, 19:12
CleanStateTracker.php:170ReplyI would be happy with this technical exception message. -
Alexander Schnitzler uploaded patch set 3
V +110/29/26, 10:42 -
core-ci voted on patch set 3 V +1 10/29/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112794
-
Alexander Schnitzler commented on patch set 3 10/29/26, 12:04
This change is ready for review. -
Oliver Klee voted on patch set 3 V +1 10/29/26, 13:33
-
Simon Schaufelberger commented on patch set 3 CR +1 V +1 10/29/26, 15:59
CleanStateTracker.php:170ReplyDone -
Alexander Schnitzler uploaded patch set 4
CR +1V +111/04/26, 08:55 -
core-ci voted on patch set 4 V +1 11/04/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113261
-
Oliver Klee voted on patch set 4 V +1 11/04/26, 11:51
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/04/26, 14:13
-
Markus Klein uploaded patch set 5
CR +1V +111/10/26, 08:13 -
core-ci voted on patch set 5 V -1 11/10/26, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113858
-
Alexander Schnitzler uploaded patch set 6
V -111/11/26, 08:24 -
core-ci voted on patch set 6 V +1 11/11/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114020
-
Oliver Klee voted on patch set 6 V +1 11/11/26, 08:38
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/15/26, 01:06