Review main Merged

96870[FEATURE] Remember the chosen workspace preview mode per user

Jens Pausewang CR +2 V +2 Normal +172 −8 updated 10/26/26, 11:27

Commit message

The preview mode a backend user selects in the workspace preview
(slider, vbox or hbox) is now stored in the user's uc under
"workspaces.previewMode". The preview module persists it via
@typo3/backend/storage/persistent, which uses the
usersettings_process AJAX route.

When the preview is opened again, PreviewController uses the stored
mode as the initial mode if it is one of the modes allowed by the
page TSconfig option "workspaces.splitPreviewModes", otherwise the
first allowed mode is used as before.

The template now renders the initial state for that mode: the stage
slider is hidden and the live frame is not collapsed unless the
active mode is "slider".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1317

  1. Jens Pausewang uploaded patch set 1 10/19/26, 15:26

  2. core-ci voted on patch set 1 V +1 10/19/26, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111668

  3. Benni Mack voted on patch set 1 CR +1 10/19/26, 20:14

  4. Josua Vogel commented on patch set 1 10/19/26, 20:45

    Index.fluid.html:16

    I think using a class would be better. There are other `style` attributes as well, but I consider this a bad practice that shouldn't be continued.
  5. Jens Pausewang uploaded patch set 2 CR +1 V +1 10/20/26, 09:02

  6. core-ci voted on patch set 2 V +1 10/20/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111772

  7. Simon Schaufelberger commented on patch set 2 10/22/26, 18:59

    Index.fluid.html:16 Reply

    Done
  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/22/26, 19:00

  9. Simon Schaufelberger commented on patch set 2 V 0 CR -1 10/22/26, 19:01

    Every feature needs a rest file. Please add one
  10. Benni Mack uploaded patch set 3 CR -1 V +1 10/23/26, 15:10

  11. Benni Mack commented on patch set 3 10/23/26, 15:13

    Reply

    Done
  12. core-ci voted on patch set 3 V -1 10/23/26, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112339

  13. Benni Mack rebased onto patch set 4 V -1 10/23/26, 21:26

  14. core-ci voted on patch set 4 V +1 10/23/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112364

  15. Josua Vogel voted on patch set 4 CR +1 V +1 10/26/26, 09:50

  16. Benni Mack voted on patch set 4 CR +2 V +2 10/26/26, 11:27

  17. Benni Mack merged patch set 5 10/26/26, 11:27