Review main Merged

96874[TASK] Recommend label domain syntax in AGENTS.md

Oli Bartsch CR +2 V +2 Easy +10 −0 updated 10/19/26, 21:07

Commit message

Since TYPO3 v14.0, labels can be referenced by their translation
domain, such as "backend.toolbar:save", instead of the full
"LLL:EXT:" path to the XLIFF file. Most of the core already uses
this syntax, yet new patches still often add file-based references.

AGENTS.md now asks for the domain syntax wherever a label is
resolved, and notes that 13.4 backports need the file-based form.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/19/26, 16:27

  2. core-ci voted on patch set 1 V +1 10/19/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111676

  3. Georg Ringer voted on patch set 1 CR +1 V +1 10/19/26, 17:32

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/19/26, 19:05

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/19/26, 19:22

  6. Oli Bartsch merged patch set 2 10/19/26, 19:22

  7. Garvin Hicking commented on patch set 2 10/19/26, 21:07

    (If you agree i can make a followup)

    AGENTS.md:190 Unresolved

    ```suggestion `LLL:EXT:<ext>/Resources/Private/Language/locallang_<resource>.xlf:<identifier>`. The ```

    AGENTS.md:195 Unresolved

    Hm I'd pefer "f:translate(key:..., domain:...)"