Review 14.3 Merged

96876[TASK] Convert intExplode values without references

Georg Ringer CR +2 V +2 Easy +4 −13 updated 10/19/26, 18:17

Commit message

Convert values in place with an indexed loop while preserving integer
casting, empty-value removal and contiguous keys. Avoid references
and keep peak memory at or below the original implementation.

Benchmarked on PHP 8.5.7, Ryzen 9 9955HX3D, OPcache enabled, JIT and
Xdebug disabled. Three runs of 15 alternating paired batches across
46 cases show median execution times 6-27% lower. Cases cover empty
input and 1-10,000 tokens, varying empty values and both removal modes.

Memory for 100,000 tokens (active PHP allocations, excluding input):
                         Before       After
Numeric IDs, peak        5.06 MiB     5.06 MiB
Numeric IDs, retained    5.06 MiB     2.00 MiB
50% removed, peak        4.53 MiB     3.53 MiB

All measured outputs match the original implementation exactly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Georg Ringer uploaded patch set 1 10/19/26, 17:38

  2. Georg Ringer commented on patch set 1 10/19/26, 17:39

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 10/19/26, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111685

  4. core-ci voted on patch set 1 V +1 10/19/26, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111685

  5. Georg Ringer voted on patch set 1 CR +2 V +2 10/19/26, 18:17

  6. Georg Ringer merged patch set 2 10/19/26, 18:17