Review 14.3 Merged

96887[BUGFIX] Render honeypot as last element of the form step

Georg Ringer CR +2 V +2 Easy +23 −10 updated 10/19/26, 20:40

Commit message

The honeypot element was inserted at a random position among the
elements of the current form step on every rendering. On uncached
pages its position therefore changed with every page load.

Firefox restores the values of form controls after a soft reload by
the index of the control within the form, not by its name. When the
honeypot moved, restored values ended up in the neighbouring field
and could even end up in the honeypot itself, failing its validation.

The honeypot is now appended as last element of the form step. Its
random name, which the spam protection relies on, is kept.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Georg Ringer commented on patch set 1 10/19/26, 20:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/19/26, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111712

  3. Georg Ringer uploaded patch set 2 V -1 10/19/26, 20:26

  4. core-ci voted on patch set 2 V +1 10/19/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111718

  5. Georg Ringer voted on patch set 2 CR +2 V +2 10/19/26, 20:40

  6. Georg Ringer merged patch set 3 10/19/26, 20:40