96890[BUGFIX] Skip subpage check for language menu items
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Oli Bartsch uploaded patch set 1 10/19/26, 20:55
-
core-ci voted on patch set 1 V +1 10/19/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111722
-
Georg Ringer commented on patch set 1 CR -1 10/23/26, 05:42
-
Oli Bartsch uploaded patch set 2
CR -1V +110/24/26, 20:25 -
Oli Bartsch commented on patch set 2 10/24/26, 20:26
AbstractMenuContentObject.php:1936Replyyes, a hardcoded 0 is misleading. I droped the key for language menu items and makes it optional in the array shape. The test keeps hasSubpages in the filter list, so it asserts the key is absent. -
core-ci voted on patch set 2 V +1 10/24/26, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112435
-
Benni Mack voted on patch set 2 CR +1 V +1 10/28/26, 12:56
-
Wouter Wolters voted on patch set 2 CR +1 V +1 10/28/26, 17:30
-
Oli Bartsch voted on patch set 2 CR +2 V +2 10/28/26, 18:26
-
Oli Bartsch merged patch set 3 10/28/26, 18:26
AbstractMenuContentObject.php:1936