Review main Merged Breaking

96900[!!!][TASK] Apply site sets in the order a site declares them

Oli Bartsch CR +2 V +2 Normal +173 −29 updated 10/22/26, 11:52

Commit message

SetRegistry::getSets() ordered the requested sets by one global
ordering of every installed set. Sets without a dependency relation
between them were ordered by the number of dependencies they declare
and by name, so installing an unrelated extension could change which
of two sets of a site wins, and the order a site lists its sets in had
no effect.

The sets are now walked in the order they are requested, each of them
preceded by the sets it depends on, and a set reached more than once
keeps its first position. TypoScript, page TSconfig, site settings,
their categories and route enhancers therefore follow the order of the
"dependencies" of a site, while a set still always comes after the
sets it depends on.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/20/26, 07:30

  2. core-ci voted on patch set 1 V +1 10/20/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111752

  3. Matthias Vogel uploaded patch set 2 V +1 10/20/26, 18:30

  4. core-ci voted on patch set 2 V +1 10/20/26, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111910

  5. Matthias Vogel voted on patch set 2 CR +1 V +1 10/20/26, 18:45

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/21/26, 06:38

  7. Georg Ringer voted on patch set 2 CR +2 V +2 10/22/26, 11:52

  8. Georg Ringer merged patch set 3 10/22/26, 11:52