Review main Merged

96909[BUGFIX] Make the context menu usable in the contextual edit sheet

Oli Bartsch CR +2 V +2 Normal +134 −3 updated 10/27/26, 21:08

Commit message

The contextual edit sheet is a modal <dialog>, which renders
everything outside of it inert. The context menu, rendered by
the single element in the backend's top document, therefore
opened behind the sheet and could not be used.

The menu is now rendered into a popover, which is mounted into
the topmost open dialog while the menu is shown, the same
approach already used for notifications.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Wouter Wolters +1
    • Jure Milic +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1317

  1. Oli Bartsch uploaded patch set 1 10/20/26, 10:10

  2. core-ci voted on patch set 1 V +1 10/20/26, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111788

  3. Oli Bartsch uploaded patch set 2 V +1 10/20/26, 12:22

  4. core-ci voted on patch set 2 V +1 10/20/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111804

  5. Lisa Kreitz voted on patch set 2 V +1 10/20/26, 13:24

  6. Garvin Hicking commented on patch set 2 V +1 10/20/26, 18:41

    Sadly can't judge the JS code but it works as advertised 😊
  7. Oli Bartsch uploaded patch set 3 V +1 10/21/26, 15:31

  8. core-ci voted on patch set 3 V +1 10/21/26, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112015

  9. Oli Bartsch rebased onto patch set 4 V +1 10/24/26, 20:33

  10. core-ci voted on patch set 4 V +1 10/24/26, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112438

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/25/26, 09:30

  12. Garvin Hicking voted on patch set 4 V +1 10/25/26, 09:44

  13. Wouter Wolters voted on patch set 4 CR +1 V +1 10/25/26, 12:02

  14. Jure Milic voted on patch set 4 V +1 10/27/26, 14:14

  15. Garvin Hicking voted on patch set 4 CR +1 10/27/26, 20:58

  16. Oli Bartsch voted on patch set 4 CR +2 V +2 10/27/26, 21:08

  17. Oli Bartsch merged patch set 5 10/27/26, 21:08