Review main Merged

96918[BUGFIX] Report links to pages hidden by a parent page

Oli Bartsch CR +2 V +2 Normal +162 −4 updated 10/28/26, 15:51

Commit message

Linkvalidator only checked the linked page itself. A page below a
page with "Extend to Subpages" that is hidden, not yet started or
expired is not visible in the frontend either, but links to it were
not reported.

The check now also walks the rootline of the linked page and reports
the link as hidden when a parent page with "Extend to Subpages" hides
it. A hidden parent page without "Extend to Subpages" still does not
affect the pages below it, as in the frontend. Access restrictions by
frontend user groups are not part of this check.

The report names the closest parent page that hides the linked page,
so editors know which page to look at.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 810

  1. Oli Bartsch uploaded patch set 1 10/20/26, 13:31

  2. core-ci voted on patch set 1 V +1 10/20/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111834

  3. Josua Vogel commented on patch set 1 10/22/26, 20:58

    what do you think about improving the error message like this: Page '###title###' (id=###uid###) is not visible, because the page '###hiddenByTitle###' (id=###hiddenByUid###) hides its subpages.
  4. Oli Bartsch uploaded patch set 2 V +1 10/22/26, 21:55

  5. Oli Bartsch commented on patch set 2 10/22/26, 21:57

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/22/26, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112189

  7. Josua Vogel commented on patch set 2 CR +1 V +1 10/23/26, 06:04

    thx!
  8. Benni Mack voted on patch set 2 CR +1 V +1 10/28/26, 15:36

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 10/28/26, 15:50

  10. Oli Bartsch merged patch set 3 10/28/26, 15:51