96920[TASK] Compare written field values in Extbase with DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 41
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/FieldValue.phpnew+138 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Identified.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Stamp.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/FieldValueRepository.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/IdentifiedRepository.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/StampRepository.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_fieldvalue.phpnew+169 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_identified.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_stamp.phpnew+28 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/Given/Base.csvnew+9 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/Given/Values.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/CreationTime.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/DateFormat.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/DuplicateSlugInPid.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/DuplicateSlugInSite.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/NativeDate.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/NativeDatetime.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/NullOnCreate.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/NullOnUpdate.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/SameSlugInOtherSite.csvnew+4 −0
Show 21 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/Slug.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldTypeValues/TcaDefaults.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/Given/Base.csvnew+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/Given/Entries.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/BelowRange.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/CutOff.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/DateAsTimestamp.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/DuplicateUnique.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/DuplicateUniqueInPid.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/EmptyRequired.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/InvalidEmail.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/NonNumeric.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/NotCutOffText.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/FieldValues/Trimmed.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Timestamp/Given/Base.csvnew+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Timestamp/Given/Posts.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Timestamp/ChangedPost.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Timestamp/CreatedPost.csvnew+5 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/FieldTypeValuesTest.phpnew+705 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/FieldValuesTest.phpnew+551 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/TimestampTest.phpnew+146 −0
Review log 78
-
Alexander Schnitzler uploaded patch set 1 10/20/26, 14:35
-
core-ci voted on patch set 1 V +1 10/20/26, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111850
-
Alexander Schnitzler marked it ready for review 10/20/26, 14:50
-
Alexander Schnitzler wrote 10/20/26, 15:22
Topic set to extbase -
Alexander Schnitzler commented on patch set 1 10/20/26, 15:54
A note up front: I'm not sure myself whether all of these pairs describe behaviour Extbase should adopt. TCA eval is how the backend form processes input, while Extbase writes usually come from frontend input that runs through Extbase validators. Roughly, the pairs fall into three groups: 1. Data integrity: password hashing, unique/uniqueInPid, generating uuid and slug values, TCA defaults of new records, crdate. If Extbase skips these, the database ends up with wrong or duplicate data. I think these are the strongest case for following DataHandler. 2. Input normalisation: trim, max, range.lower, email. One could argue this is validation and belongs to Extbase validators, not to the persistence layer. 3. Required fields: an empty value overwriting the old value of a required field sits somewhere in between. If group 2 (or 3) should not be expected from Extbase, I'd rather drop those pairs than pin them as differences. Opinions welcome. -
Benni Mack commented on patch set 1 10/20/26, 16:13
Reply
that is correct. I typically call it: - Validation - Sanitization / Normalization We really need to validate, but DAtaHandler cannot deal with required fields properly set, this is something we need to improve in v15/v16 still. So: 3 Should be handled on the Domain Level in Extbase for the time being. -
Benni Mack commented on patch set 1 CR +2 V +2 10/20/26, 19:29
Reply
Done -
Benni Mack merged patch set 2 10/20/26, 19:29