Review main Merged

96922[TASK] Compare writing to-one relations in Extbase with DataHandler

Alexander Schnitzler CR +2 V +2 Expert +1036 −0 updated 10/20/26, 16:32

Commit message

Writing a relation to a single record through an Extbase repository
and through the backend form should leave the database in the same
state. This adds ToOneRelationTest with pairs of functional tests on
blog_example: a ByCore test sends what the backend form sends to
DataHandler as an admin, a ByExtbase test does the same through the
repository and expects the same rows.

The pairs clear, replace and move the featured post of a blog
(inline with foreign_field, oneToOne) and the avatar of a person
(file field with maxitems 1), clear and replace the author (select)
of a post, clear and replace the pinned tag (group, maxitems 1) of
a person, and set, clear and replace the main tag of a person
(select with MM, maxitems 1).

Extbase differs from DataHandler in ten of them. Those ByExtbase
tests are skipped and describe the difference:
- clearing an inline child or a file reference leaves it undeleted
- replacing an inline child or a file reference stores its uid in
  the parent field instead of the number of records and leaves the
  old record undeleted
- moving an inline child or a file reference does not change the
  field of the record that points to the parent
- clearing a group field with maxitems 1 writes the string 0 instead
  of the empty string
- setting, clearing and replacing a select with MM and maxitems 1
  does not write or delete relation rows and stores the uid of the
  tag in the field instead of the number of records

blog_example gets the fields avatar, main_tag and pinned_tag on the
person in TCA override files, with matching properties on the Person
model.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 25

Show 5 more files

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 10/20/26, 14:45

  2. core-ci voted on patch set 1 V +1 10/20/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111852

  3. Alexander Schnitzler marked it ready for review 10/20/26, 14:59

  4. Alexander Schnitzler wrote 10/20/26, 15:22

    Topic set to extbase
  5. Oliver Klee voted on patch set 1 V +1 10/20/26, 16:10

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/20/26, 16:32

  7. Benni Mack merged patch set 2 10/20/26, 16:32