Review main Merged

96923[TASK] Compare translating records in Extbase with DataHandler

Alexander Schnitzler CR +2 V +2 Expert +1046 −0 updated 10/20/26, 16:24

Commit message

Creating and changing translations through an Extbase repository and
localizing and editing them in the backend should leave the database
in the same state. This adds TranslationWriteTest and
TranslationInlineChildrenTest with pairs of functional tests on
blog_example: a ByCore test works through DataHandler as an admin, a
ByExtbase test does the same through the repository and expects the
same rows.

The pairs cover localizing a record, copied and prefixed values,
changing a translation, a synchronized field, a record for all
languages, hidden new translations, moving a record with its
translations, copies of excluded inline children for translations
and the language of new inline and file children.

Extbase differs from DataHandler in eleven of them. Those ByExtbase
tests are skipped and describe the difference:
- a new translation is not linked to the default record
- the language prefix of a field is not written
- changing a translation writes no l18n_diffsource and l10n_state
- a synchronized field is not written into the translation
- a new translation of a table with hideAtCopy is not hidden
- setting the pid of an object does not move it with its translations
- saving the default record creates no copies of excluded children
  for its translation
- saving the default record with two translations creates no copies
  for the last translation
- a new child of a translation gets language 0 instead of the
  language of the translation
- a new file reference of a translation gets language 0
- a new child of a new translated record gets language 0

blog_example gets a TCA override for blogs, which synchronizes the
subtitle and prefixes the description, and a TCA override for infos
with hideAtCopy.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 27

Show 7 more files

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 10/20/26, 14:47

  2. core-ci voted on patch set 1 V +1 10/20/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111853

  3. Alexander Schnitzler marked it ready for review 10/20/26, 14:59

  4. Alexander Schnitzler wrote 10/20/26, 15:22

    Topic set to extbase
  5. Oliver Klee voted on patch set 1 V +1 10/20/26, 16:10

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/20/26, 16:24

  7. Benni Mack merged patch set 2 10/20/26, 16:24