Review main Merged

96928[TASK] Compare reading translated records in Extbase with CONTENT

Alexander Schnitzler CR +2 V +2 Expert +1003 −0 updated 10/21/26, 05:19

Commit message

Reading translated records through an Extbase repository and
selecting them the way the CONTENT cObject does should return the
same records. This adds ReadingTranslationsTest with pairs of
functional tests on blog_example: a ByCore test selects with
ContentObjectRenderer::getRecords() (a single record with the
RECORDS cObject) and a ByExtbase test reads through the repository
with the same language aspect and expects the same posts.

The pairs cover reading all posts with overlays on, mixed, on with
floating and off, reading with a fallback chain, counting, ordering
by sorting, a query without language restriction, finding a post by
the uid of the default record or of its translation, and a record
for all languages.

Extbase differs from the core in eleven of them. Those ByExtbase
tests are skipped and describe the difference:
- overlays mixed does not return the translation without default
  record, which also changes the count
- overlays off returns translations under the uid of their default
  record
- a fallback chain with overlays on selects only rows in the
  requested language, which also changes the count
- ordering by sorting uses the sorting of the translations, with
  overlays on and mixed
- a query without language restriction returns a record once per
  row and counts the rows of every language
- an in() constraint on the uid of a default record finds none of
  its translations
- findByUid() of a translation returns it under the uid of its
  default record

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 10/20/26, 15:02

  2. Alexander Schnitzler wrote 10/20/26, 15:22

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 10/20/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111861

  4. Alexander Schnitzler marked it ready for review 10/20/26, 15:42

  5. Oliver Klee voted on patch set 1 V +1 10/20/26, 16:09

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/20/26, 17:24

  7. Benni Mack commented on patch set 1 CR +2 V +2 10/21/26, 05:19

    very very valuable. We now know how it works, and can then align via bugfixes and see implications! Thank you
  8. Benni Mack merged patch set 2 10/21/26, 05:19