Review main Merged

96931[TASK] Compare Extbase visibility with CONTENT and the core

Alexander Schnitzler CR +2 V +2 Expert +1233 −0 updated 10/21/26, 05:18

Commit message

Which records Extbase returns when they are hidden, not started,
ended, restricted to a user group or soft-deleted should match what
the core shows in the frontend. This adds VisibilityTest and
ChildVisibilityTest with pairs of functional tests on blog_example:
a ByCore test reads through the CONTENT object (getRecords()), the
record API or a QueryBuilder with the frontend restrictions, a
ByExtbase test reads through a repository and expects the same
titles.

The pairs cover hidden, start and end time and user group
restrictions, hidden translations with overlays on and mixed,
ignored enable fields (hidden, user groups, all), hidden MM tags
and inline comments, constraints on a hidden tag, included deleted
records, storage pages that are hidden, and the visibility of
inline and MM children.

Extbase differs from the core in three of them. Those ByExtbase
tests are skipped and describe the difference:
- posts on a hidden storage page are returned
- posts of a hidden page are returned when reading it with its
  subpages
- includeDeleted without ignoreEnableFields throws in the frontend

blog_example gets the enable fields starttime, endtime and fe_group
on posts and tags, in override files of their own.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 10/20/26, 15:17

  2. Alexander Schnitzler wrote 10/20/26, 15:22

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 10/20/26, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111866

  4. Alexander Schnitzler marked it ready for review 10/20/26, 15:42

  5. Oliver Klee voted on patch set 1 V +1 10/20/26, 16:09

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/21/26, 05:18

  7. Benni Mack merged patch set 2 10/21/26, 05:18