Review main Merged

96937[TASK] Compare history, log and reference index with DataHandler

Alexander Schnitzler CR +2 V +2 Hard +911 −0 updated 10/20/26, 16:37

Commit message

Creating, changing and deleting a record through an Extbase
repository should leave the same traces in sys_history, sys_log and
sys_refindex as the same change in the backend. This adds HistoryTest,
LogTest and ReferenceIndexTest with pairs of functional tests on
blog_example: a ByCore test changes a post through DataHandler as an
admin, a ByExtbase test does the same through the repository and
expects the same rows.

The pairs cover the history of a created, changed, translated and
deleted post, history tracking in its default configuration, the log
entries of creating, changing and deleting, and the reference index
of an MM relation on the changed post (related posts) and of the
opposite side of one (tags), each after attaching to a post and
detaching the last one.

Extbase differs from DataHandler in nine of them. Those ByExtbase
tests are skipped and describe the difference:
- creating a post writes an add and a modify history entry with the
  object properties instead of the database fields
- changing a post writes the whole property set of the object to the
  history instead of the changed fields
- changing a translation is recorded on the uid of the default record
- history is not written while extbase.enableHistoryTracking is off
- creating, changing and deleting write no sys_log entry
- only the reference index of the changed post is updated, so the
  rows of the tags (field items) are neither written nor removed

The reference index pairs for the related posts of a post behave
like DataHandler, as the relation is defined on the changed post.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 10/20/26, 15:44

  2. Alexander Schnitzler wrote 10/20/26, 15:49

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 10/20/26, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111876

  4. Alexander Schnitzler marked it ready for review 10/20/26, 15:57

  5. Oliver Klee voted on patch set 1 V +1 10/20/26, 16:08

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/20/26, 16:36

  7. Benni Mack merged patch set 2 10/20/26, 16:37