Review main Merged

96949[TASK] Replace deprecated expectExceptionMessage in Tests

Simon Schaufelberger CR +2 V +2 Normal +100 −100 updated 10/21/26, 18:30

Commit message

Replace expectExceptionMessage in Unit/Functional Tests with
expectExceptionMessageIs and expectExceptionMessageIsOrContains

see https://github.com/sebastianbergmann/phpunit/issues/6560

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 42

Show 22 more files

Review log 1217

  1. Simon Schaufelberger uploaded patch set 1 10/20/26, 17:54

  2. Simon Schaufelberger uploaded patch set 2 10/20/26, 18:02

  3. core-ci voted on patch set 2 V -1 10/20/26, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111903

  4. Wouter Wolters commented on patch set 2 10/20/26, 18:28

    If I remember correctly this is not in PHPunit being used by 14.3. Therefor I think this is not worth it yet.
  5. Simon Schaufelberger commented on patch set 2 10/20/26, 19:03

    Reply

    yes, 14.3 uses "phpunit/phpunit": "^11.5.56",
  6. Simon Schaufelberger uploaded patch set 3 V -1 10/20/26, 19:09

  7. core-ci voted on patch set 3 V -1 10/20/26, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111927

  8. Simon Schaufelberger uploaded patch set 4 V -1 10/20/26, 19:45

  9. core-ci voted on patch set 4 V -1 10/20/26, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111931

  10. Simon Schaufelberger uploaded patch set 5 V -1 10/20/26, 20:05

  11. core-ci voted on patch set 5 V -1 10/20/26, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111936

  12. Simon Schaufelberger uploaded patch set 6 V -1 10/20/26, 21:02

  13. core-ci voted on patch set 6 V +1 10/20/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111937

  14. Oliver Klee voted on patch set 6 V +1 10/20/26, 21:42

  15. Oli Bartsch voted on patch set 6 CR +1 V +1 10/21/26, 17:31

  16. Oli Bartsch voted on patch set 6 CR +2 V +2 10/21/26, 18:30

  17. Oli Bartsch merged patch set 7 10/21/26, 18:30