Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Quiet

96952[TASK] Reuse rootlines from slug candidates

Wouter Wolters CR 0 V 0 Normal +208 −4 updated 10/22/26, 19:24

Commit message

Slug candidates often include every ancestor needed to identify their
site. Reuse these records through SiteFinder's existing rootline
argument instead of loading a persisted rootline for each matching
page.

Only reuse complete live, default-language chains. Keep the existing
resolver for missing ancestors, cycles, translations and workspaces.

With 100 sites and 100 pages per site, a local warm frontend request
performs 6 SQL statements instead of 105. Its median time falls from
71.8 ms to 26.5 ms.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/96952/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/96952/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Files 4

Review log 3

  1. Wouter Wolters uploaded patch set 1 10/20/26, 18:31

  2. Wouter Wolters wrote 10/22/26, 18:40

    Unset private
  3. Oli Bartsch commented on patch set 1 10/22/26, 19:24

    PageSlugCandidateProvider.php:217 Unresolved

    The `&& $languageId === 0` guard changes nothing. For `languageId > 0` the map is keyed by translation uids, while the lookup uses `l10n_parent`, so it always falls back anyway. Please either keep it and add a comment saying it is intentional, or drop it. Also, `resolvesTranslatedCandidatesWithDefaultLanguageRootlines` doesn't actually cover the guard (removing it left all tests green).