Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96952[TASK] Reuse rootlines from slug candidates
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/96952/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/96952/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
Files 4
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php1+26 −4
- typo3/sysext/core/Tests/Functional/Routing/Fixtures/CountingRootlineBackend.phpnew+31 −0
- typo3/sysext/core/Tests/Functional/Routing/Fixtures/SlugCandidates.csvnew+17 −0
- typo3/sysext/core/Tests/Functional/Routing/PageSlugCandidateProviderTest.phpnew+134 −0
Review log 3
-
Wouter Wolters uploaded patch set 1 10/20/26, 18:31
-
Wouter Wolters wrote 10/22/26, 18:40
Unset private -
Oli Bartsch commented on patch set 1 10/22/26, 19:24
PageSlugCandidateProvider.php:217UnresolvedThe `&& $languageId === 0` guard changes nothing. For `languageId > 0` the map is keyed by translation uids, while the lookup uses `l10n_parent`, so it always falls back anyway. Please either keep it and add a comment saying it is intentional, or drop it. Also, `resolvesTranslatedCandidatesWithDefaultLanguageRootlines` doesn't actually cover the guard (removing it left all tests green).