96953[FEATURE] Show site sets in the Configuration module
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 2
Files 8
- Build/tests/playwright/e2e/configuration/configuration-module-provider.spec.ts+46 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111183-SiteSetsInConfigurationModule.rstnew+41 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SiteSetsProvider.php3new+64 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+12 −2
- typo3/sysext/lowlevel/Documentation/BackendModules/Configuration.rst+25 −0
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf3+3 −0
- typo3/sysext/lowlevel/Tests/Functional/ConfigurationModuleProvider/ProviderRegistryOrderTest.php+2 −1
- typo3/sysext/lowlevel/Tests/Functional/ConfigurationModuleProvider/SiteSetsProviderTest.phpnew+124 −0
Review log 1115
-
Matthias Vogel uploaded patch set 1 10/20/26, 18:34
-
Matthias Vogel uploaded patch set 2 10/20/26, 18:43
-
Matthias Vogel rebased onto patch set 3 10/20/26, 18:43
-
core-ci voted on patch set 1 V -1 10/20/26, 18:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111912
-
core-ci voted on patch set 2 V +1 10/20/26, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111914
-
Matthias Vogel commented on patch set 3 10/20/26, 18:52
This change is ready for review. -
core-ci voted on patch set 3 V +1 10/20/26, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111915
-
Georg Ringer voted on patch set 3 CR +1 V +1 10/21/26, 19:50
-
Benjamin Franzke commented on patch set 3 10/23/26, 08:36
SiteSetsProvider.php:40Since you sort by key name, you don't actually show the (*global*) loading order. The loading order is "only" shown within the `sites` subarray. Why don't you want to show the global loading order here?locallang.xlf:67I feel the suffix "(Load Order)" is superfluous. Your intent – which I support – is to debug loading order, yes, but since it does more (shows settings and other details), this title is a bit too scoped. -
Matthias Vogel uploaded patch set 4
CR +1V +110/23/26, 11:09Preserve registry order and shorten label; rebase on main -
core-ci voted on patch set 4 V +1 10/23/26, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112281
-
Matthias Vogel commented on patch set 4 10/23/26, 11:44
SiteSetsProvider.php:40ReplyChanged the ordering.locallang.xlf:67ReplyChanged the provider label. -
Benjamin Franzke commented on patch set 4 CR +1 V +1 10/28/26, 09:11
SiteSetsProvider.php:40ReplyAcknowledgedlocallang.xlf:67ReplyAcknowledged -
Garvin Hicking voted on patch set 4 CR +2 V +2 10/28/26, 09:21
-
Garvin Hicking merged patch set 5 10/28/26, 09:21