Review main Merged

96960[TASK] Skip Extbase DISTINCT ordering by joined field on MySQL

Alexander Schnitzler CR +2 V +2 Easy +6 −4 updated 10/21/26, 07:35

Commit message

The Extbase side of the pair that finds posts by tag names and orders
them by the last name of their author selects with SELECT DISTINCT
and orders by a column of a joined table. MySQL rejects this like
PostgreSQL does, so the test is skipped on MySQL as well. MariaDB
and SQLite accept the query.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 10/21/26, 06:49

  2. Alexander Schnitzler commented on patch set 1 10/21/26, 06:54

    QueryingTest.php:192 Unresolved

    Why `markTestSkipped()` and not `#[Group('not-postgres')]` / `#[Group('not-mysql')]`: this is the Extbase half of a ByCore/ByExtbase pair. On PostgreSQL and MySQL the test does not just "not apply", Extbase behaves differently from the core there (the `SELECT DISTINCT` it generates for the to-many constraint cannot be ordered by a joined column, see #92514). A group would silently exclude the test on these DBMS, so the difference would vanish from the run. The skip keeps the test visible as skipped, with the reason "Extbase differs from core: …", which is also what we use to document the deviation per DBMS. Once #92514 is fixed, the condition can simply be removed and the test runs everywhere.
  3. core-ci voted on patch set 1 V +1 10/21/26, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111970

  4. Alexander Schnitzler commented on patch set 1 10/21/26, 07:12

    This change is ready for review.
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 10/21/26, 07:20

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 10/21/26, 07:35

  7. Garvin Hicking merged patch set 2 10/21/26, 07:35