96967[TASK] Soft-fail and show broken site configurations
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 41
- Build/Scripts/runTests.sh+1 −1
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+83 −13
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php+8 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+9 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+7 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+27 −0
- typo3/sysext/backend/Resources/Private/Partials/SiteManagement/InvalidSite.fluid.htmlnew+18 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Edit.fluid.html+10 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.fluid.html+79 −1
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/InvalidSites/sites/broken-yaml/config.yamlnew+2 −0
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/InvalidSites/sites/invalid-language-base/config.yamlnew+13 −0
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/InvalidSites/sites/valid/config.yamlnew+8 −0
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/InvalidSites/pages.csvnew+5 −0
- typo3/sysext/backend/Tests/Functional/Controller/SiteConfigurationControllerInvalidSitesTest.phpnew+242 −0
- typo3/sysext/core/Classes/Command/SiteListCommand.php+16 −3
- typo3/sysext/core/Classes/Command/SiteValidateCommand.phpnew+168 −0
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+7 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+201 −40
- typo3/sysext/core/Classes/Exception/InvalidSiteConfigurationException.phpnew+36 −0
- typo3/sysext/core/Classes/Site/Entity/Site.php+46 −4
Show 21 more files
- typo3/sysext/core/Classes/Site/SiteFinder.php+13 −0
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-110913-BrokenSiteConfigurationsAreSkippedAndReported.rstnew+87 −0
- typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Command/SiteValidateCommandTest.phpnew+102 −0
- typo3/sysext/core/Tests/Functional/Command/SiteValidateCommandValidSitesTest.phpnew+234 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/broken-csp/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/broken-csp/csp.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/broken-yaml/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/empty-env-base/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/invalid-base/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/invalid-base-variant/config.yamlnew+9 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/invalid-language-base/config.yamlnew+13 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/missing-locale/config.yamlnew+7 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/missing-root-page-id/config.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/InvalidSites/valid/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/SiteConfigurationInvalidSitesTest.phpnew+176 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+64 −7
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+40 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/InvalidSiteTestPageImport.csvnew+13 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/InvalidSiteTest.phpnew+90 −0
Review log 711
-
Garvin Hicking commented on patch set 1 10/21/26, 09:29
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php * typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php * typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php -
core-ci voted on patch set 1 V -1 10/21/26, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111985
-
Garvin Hicking uploaded patch set 2
V -110/21/26, 10:01backport -
core-ci voted on patch set 2 V +1 10/21/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111989
-
Garvin Hicking commented on patch set 3
V +110/30/26, 10:37Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php * typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php * typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php -
Garvin Hicking uploaded patch set 4 10/30/26, 10:41
backport -
core-ci voted on patch set 3 V -1 10/30/26, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112849
-
Garvin Hicking marked it ready for review 10/30/26, 10:45
-
core-ci voted on patch set 4 V +1 10/30/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112851
-
Garvin Hicking voted on patch set 4 CR +2 V +2 10/30/26, 10:53
-
Garvin Hicking merged patch set 5 10/30/26, 10:53