Review main Merged

96977[BUGFIX] Keep context menu actions within the contextual edit sheet

Oli Bartsch CR +2 V +2 Hard +467 −116 updated 11/01/26, 16:36

Commit message

Context menu actions used from within a contextual edit sheet
navigated the content frame behind the sheet, so their result
was not visible until the sheet was closed.

Context menu actions used from within a sheet now respect it:

* "Edit" opens the record in a nested sheet. Once the nested
  sheet saved and closed, the sheet below is reloaded to show
  the change.
* Actions committing a record, e.g. "Disable", keep the sheet
  open and reload it afterwards.
* Other actions navigating the content frame close the sheet.

The sheet replaces FormEngine as navigation guard for this and
confirms unsaved changes before it is reloaded or closed.
Saving is offered, unless the record was just saved in a
nested sheet, which the outdated form would revert.

Sheets are now opened by the top window, since the content
frame they are triggered from may be reloaded while they are
open, which left the sheet without its event handlers. Each
sheet only handles messages of its own iframe.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 710

  1. Oli Bartsch uploaded patch set 1 10/21/26, 15:31

  2. core-ci voted on patch set 1 V +1 10/21/26, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112016

  3. Oli Bartsch uploaded patch set 2 V +1 10/24/26, 20:33

  4. core-ci voted on patch set 2 V +1 10/24/26, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112439

  5. Oli Bartsch rebased onto patch set 3 V +1 10/27/26, 21:09

  6. core-ci voted on patch set 3 V +1 10/27/26, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112663

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 10/28/26, 18:46

  8. Georg Ringer voted on patch set 3 CR +1 V +1 11/01/26, 16:17

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 11/01/26, 16:36

  10. Oli Bartsch merged patch set 4 11/01/26, 16:36