Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96978[FEATURE] Distinct actions for checkbox and dropdown
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/96978/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/96978/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 22
- Build/Sources/TypeScript/backend/form-engine/element/table-permission-element.ts+14 −4
- Build/Sources/TypeScript/backend/tests/multi-record-selection-test.tsnew+386 −0
- Build/Sources/TypeScript/backend/multi-record-selection.ts8+190 −44
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+6 −3
- Build/tests/playwright/e2e/media/file-upload-selection.spec.tsnew+86 −0
- Build/tests/playwright/e2e/records/multi-record-selection.spec.tsnew+109 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+6 −3
- typo3/sysext/backend/Classes/Form/Element/TablePermissionElement.php2+14 −10
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+6 −3
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/table-permission-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection.js+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-108748-SelectAllCheckboxInMultiRecordSelection.rstnew+67 −0
- typo3/sysext/filelist/Classes/FileList.php+6 −3
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.fluid.html+6 −3
- typo3/sysext/reactions/Tests/Functional/Controller/ManagementControllerTest.php+3 −1
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.fluid.html+6 −4
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.fluid.html2+6 −3
- typo3/sysext/redirects/Resources/Private/Templates/QrCode/Overview.fluid.html+6 −3
- typo3/sysext/redirects/Resources/Private/Templates/ShortUrl/Overview.fluid.html+6 −3
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.fluid.html+9 −3
Review log 710
-
Simon Schaufelberger uploaded patch set 1 10/21/26, 15:59
-
core-ci voted on patch set 1 V +1 10/21/26, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112020
-
Oli Bartsch commented on patch set 1 V -1 10/21/26, 17:30
Hi Simon, thanks for working on this. I've added a few things I'd like you to change. Generally, please add JS tests for the state logic, e2e tests for the click path (including the disabled and radio cases), and an RST entry (Important, or Feature) describing the new markup. Feature-95068 documented the old markup. And additionally, the `Signed-off-by` line has no e-mail address, so it is not a valid sign-off. Please also use `Releases: main` only, as a markup and UX change should not go to 14.3.multi-record-selection.ts:144the partial state uses `actions-selection-elements-invert`, which means "Toggle selection" in the dropdown, but the click checks all. I'd use a real `<input type="checkbox" class="form-check-input">` with `.indeterminate` for the partial state, as the issue suggests; `:indeterminate` is already styled in `_form-check.scss:96` and `:144`. This also removes the icon swapping and gives screen readers checked, unchecked and mixed for free (with a stable `aria-label`). It also fixes the static "Check all" title in `FileList.php:1476`.multi-record-selection.ts:416the state is only recomputed on `multiRecordSelection:checkbox:state:changed` and once in `restoreTemporaryState`. It goes stale when rows are replaced or enabled without a change event (recycler pagination, an enabled uploaded file in the Filelist, FormEngine inline records loaded via AJAX). Computing the state from the native checkbox when it is used avoids this; otherwise recompute on render and on interaction.multi-record-selection.ts:475`hasUnchecked` and the state counts include disabled checkboxes, while `changeCheckboxState` skips them. A disabled upload queue row in the filelist (`drag-uploader.ts:778`) leaves the button stuck in check-all mode. Please count only `:not(:disabled)` checkboxes.multi-record-selection.ts:481please don't reuse `.t3js-multi-record-selection-check-actions-toggle` for the new button. Existing markup (e.g. third-party modules copying the core pattern) still has that class on its dropdown trigger, so the menu would no longer open and all rows get toggled instead. Give the new button its own class, for example `t3js-multi-record-selection-check-actions-check-toggle`, and keep the old class meaning "opens the menu". The second `updateDropdownItems` binding (line 454) and the `preventDefault` should then no longer be needed.TablePermissionElement.php:250the new button is added to every permission column, but these cells are radios. On a fresh `be_groups` record "Check all" tries to uncheck everything, and checking all in one column unchecks the siblings in other columns without change events, so their icons go stale. Please respect the allowed actions per column: no toggle for radio columns, or check-all only (the "none" column offered only that before).Overview.fluid.html:80replacing `div.dropdown` with `div.btn-group` drops the `.dropdown` class, which the converter only adds for `data-bs-toggle` triggers (`dropdown.ts:294-296`). That removes `anchor-scope: --dropdown` and the menu may anchor to the wrong element. I haven't checked this in a browser. Please use `class="btn-group dropdown"` in all three redirects templates (Redirects, QR codes, Short URLs). -
Simon Schaufelberger uploaded patch set 2
V +110/22/26, 15:16 -
core-ci voted on patch set 2 V +1 10/22/26, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112126
-
Simon Schaufelberger uploaded patch set 3
V +110/22/26, 15:47 -
Simon Schaufelberger commented on patch set 3 10/22/26, 15:58
multi-record-selection.ts:416Reply UnresolvedThe recycler is pretty difficult as it uses ajax and not a full refresh like the other records. Any idea how to solve this? -
core-ci voted on patch set 3 V +1 10/22/26, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112138
-
Simon Schaufelberger commented on patch set 3 11/04/26, 14:35
multi-record-selection.ts:144ReplyDonemulti-record-selection.ts:475ReplyDonemulti-record-selection.ts:481ReplyDoneTablePermissionElement.php:250ReplyDoneOverview.fluid.html:80ReplyDone -
Simon Schaufelberger commented on patch set 3 11/04/26, 14:35
Reply
Done