Review main Merged

96980[BUGFIX] Leave out text when GD has no FreeType support

Benjamin Kott CR +2 V +2 Hard +543 −11 updated 10/22/26, 15:17

Commit message

PHP built with FreeType support but linked against a libgd without it,
as PHP compiled to WebAssembly, has imagettftext() and imagettfbbox()
and reports FreeType support in gd_info(), yet every call fails with a
warning. GIFBUILDER TEXT objects and the text tests of the install tool
failed, while its environment check claimed FreeType support.

Whether GD renders text is now measured once with a bundled font.
Without it, GIFBUILDER leaves out TEXT objects and the SHADOW, EMBOSS
and OUTLINE objects referring to them, and it logs a warning once per
request. The install tool skips its text tests and reports the missing
FreeType support.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 34

  1. Benjamin Kott uploaded patch set 1 10/21/26, 17:33

  2. core-ci voted on patch set 1 V +1 10/21/26, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112028

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/22/26, 15:17

  4. Benni Mack merged patch set 2 10/22/26, 15:17