Review main Merged

96992[BUGFIX] Keep selection after page tree filter reset

Markus Timtner CR +2 V +2 Hard +241 −21 updated 10/23/26, 12:43

Commit message

Nodes restored after clearing the page tree filter lacked the proxy that
updates the tree, so the former selection stayed highlighted, pages
could not be expanded anymore and a page that was not visible before
filtering lost its selection.

The restored nodes are observed again and keep the state they had
before filtering. The active page is looked up again after the filter
was reset, its parents are expanded and it is scrolled into view, so it
stays visible even when its branch was collapsed or it lies outside the
visible area of the tree. Refreshing a tree that was never filtered no
longer counts as a filter reset.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 3

Files 10

Review log 1016

  1. Markus Timtner uploaded patch set 1 10/22/26, 08:37

  2. core-ci voted on patch set 1 V +1 10/22/26, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112075

  3. Oli Bartsch uploaded patch set 2 V +1 10/22/26, 08:47

  4. core-ci voted on patch set 2 V -1 10/22/26, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112077

  5. Markus Timtner uploaded patch set 3 V -1 10/22/26, 10:28

  6. core-ci voted on patch set 3 V +1 10/22/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112089

  7. core-ci voted on patch set 2 V +1 10/22/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112077

  8. Benjamin Kott uploaded patch set 4 V +1 10/23/26, 10:32

  9. Benjamin Kott voted on patch set 4 CR +1 V +1 10/23/26, 11:04

  10. core-ci voted on patch set 4 V -1 10/23/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112269

  11. Benjamin Kott rebased onto patch set 5 CR +1 V +1 10/23/26, 11:48

  12. core-ci voted on patch set 5 V +1 10/23/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112287

  13. Benjamin Franzke voted on patch set 5 CR +1 V +1 10/23/26, 12:20

  14. Benjamin Kott voted on patch set 5 CR +2 10/23/26, 12:21

  15. Benjamin Kott voted on patch set 5 V +2 10/23/26, 12:30

  16. Benjamin Kott merged patch set 6 10/23/26, 12:43