Review main Abandoned

96999[BUGFIX] Allow renaming between allowed text file extensions

Markus Timtner CR -2 V 0 Normal +66 −3 updated 11/10/26, 18:41

Commit message

Renaming "test.txt" to "test.css", or back, was denied by the
MIME type consistency check. The check used the MIME type stored
in the file index, which had been guessed from the old file name.

The MIME type is now determined from the file contents using the
target file name whenever the extension changes, as is already
done for uploads and replacements. Contents that do not match
the new extension, e.g. an image renamed to "txt", are still
denied.

Review

  • Code review CR -2
    • Garvin Hicking -2
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Markus Timtner uploaded patch set 1 10/22/26, 11:25

  2. core-ci voted on patch set 1 V +1 10/22/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112094

  3. Garvin Hicking uploaded patch set 2 V +1 11/03/26, 18:53

  4. core-ci voted on patch set 2 V +1 11/03/26, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113203

  5. Garvin Hicking commented on patch set 2 CR -2 11/03/26, 19:10

    Unresolved

    Will need to check something
  6. Georg Ringer abandoned the change 11/10/26, 18:41

    see private msg