Review main Merged

97009[BUGFIX] Show focus outline on last breadcrumb item

Myrna Gönnemann CR +2 V +2 Easy +3 −2 updated 10/22/26, 16:42

Commit message

The last item in the doc-header breadcrumb used overflow: hidden to
truncate long labels. As a side effect, this clipped the focus outline,
so keyboard users could not see when the item was focused.

overflow: hidden is replaced by min-width: 0, which keeps long labels
truncated while the focus outline is fully visible again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Thomas Maroschik +1
    • Matthias Vogel +1
    • Martin Adler +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Thomas Maroschik +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1416

  1. Myrna Gönnemann uploaded patch set 1 10/22/26, 15:19

  2. Matthias Vogel voted on patch set 1 CR +1 V +1 10/22/26, 15:23

  3. Thomas Maroschik voted on patch set 1 CR +1 V +1 10/22/26, 15:24

  4. Oli Bartsch commented on patch set 1 CR -2 10/22/26, 15:27

    Needs Review
  5. core-ci voted on patch set 1 V +1 10/22/26, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112128

  6. Andreas Kienast commented on patch set 1 CR +1 10/22/26, 15:45

    Glad to be part of this, what a time to be alive.
  7. Oli Bartsch commented on patch set 1 10/22/26, 15:55

    Thanks for fixing the missing focus outline on the last breadcrumb item, that's a nice catch. * `Build/Sources/Sass/component/_breadcrumb.scss:74`: Please don't just remove `&:last-child { overflow: hidden; }`. That rule is what lets the last flex item shrink, so without it a long label no longer gets its ellipsis and the breadcrumb overflows its column (the styleguide demo "Collapsible Webcomponent: Overflow" breaks too). Replace it with `&:last-child { min-width: 0; }`, which keeps the shrinking but doesn't clip the outline, and rebuild `backend.css`. The 14.3 backport needs the same change. * `COMMIT_MSG:3`: The body calls the `overflow: hidden` "superflous", which is a typo and also not accurate, since it enables the truncation. Please explain that it clipped the focus outline and that `min-width: 0` is used instead so long labels are still truncated. The subject also needs "shows" and is a bit long, e.g. `[BUGFIX] Show focus outline on last breadcrumb item`. * Optional: Please mention in the commit or on Gerrit that you checked the 120px overflow demo and keyboard focus on the last item, since CI covers neither.
  8. Myrna Gönnemann uploaded patch set 2 CR +1 V +1 10/22/26, 16:09

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. Myrna Gönnemann commented on patch set 2 10/22/26, 16:13

    Reply

    Acknowledged
  10. core-ci voted on patch set 2 V +1 10/22/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112146

  11. Oli Bartsch commented on patch set 2 CR +1 V +1 10/22/26, 16:24

    Reply

    Thank you for the adjustments. works like a charm! 🧡
  12. Thomas Maroschik voted on patch set 2 CR +1 V +1 10/22/26, 16:27

  13. Matthias Vogel voted on patch set 2 CR +1 V +1 10/22/26, 16:34

  14. Martin Adler commented on patch set 2 CR +1 10/22/26, 16:34

    Well done, Myrna!
  15. Oli Bartsch voted on patch set 2 CR +2 V +2 10/22/26, 16:42

  16. Oli Bartsch merged patch set 3 10/22/26, 16:42