97009[BUGFIX] Show focus outline on last breadcrumb item
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Thomas Maroschik +1
- Matthias Vogel +1
- Martin Adler +1
-
Verified V +2 Done
- Oli Bartsch +2
- Thomas Maroschik +1
- Matthias Vogel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Myrna Gönnemann uploaded patch set 1 10/22/26, 15:19
-
Matthias Vogel voted on patch set 1 CR +1 V +1 10/22/26, 15:23
-
Thomas Maroschik voted on patch set 1 CR +1 V +1 10/22/26, 15:24
-
Oli Bartsch commented on patch set 1 CR -2 10/22/26, 15:27
Needs Review -
core-ci voted on patch set 1 V +1 10/22/26, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112128
-
Andreas Kienast commented on patch set 1 CR +1 10/22/26, 15:45
Glad to be part of this, what a time to be alive. -
Oli Bartsch commented on patch set 1 10/22/26, 15:55
Thanks for fixing the missing focus outline on the last breadcrumb item, that's a nice catch. * `Build/Sources/Sass/component/_breadcrumb.scss:74`: Please don't just remove `&:last-child { overflow: hidden; }`. That rule is what lets the last flex item shrink, so without it a long label no longer gets its ellipsis and the breadcrumb overflows its column (the styleguide demo "Collapsible Webcomponent: Overflow" breaks too). Replace it with `&:last-child { min-width: 0; }`, which keeps the shrinking but doesn't clip the outline, and rebuild `backend.css`. The 14.3 backport needs the same change. * `COMMIT_MSG:3`: The body calls the `overflow: hidden` "superflous", which is a typo and also not accurate, since it enables the truncation. Please explain that it clipped the focus outline and that `min-width: 0` is used instead so long labels are still truncated. The subject also needs "shows" and is a bit long, e.g. `[BUGFIX] Show focus outline on last breadcrumb item`. * Optional: Please mention in the commit or on Gerrit that you checked the 120px overflow demo and keyboard focus on the last item, since CI covers neither. -
Myrna Gönnemann uploaded patch set 2
CR +1V +110/22/26, 16:09Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Myrna Gönnemann commented on patch set 2 10/22/26, 16:13
Reply
Acknowledged -
core-ci voted on patch set 2 V +1 10/22/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112146
-
Oli Bartsch commented on patch set 2 CR +1 V +1 10/22/26, 16:24
Reply
Thank you for the adjustments. works like a charm! 🧡 -
Thomas Maroschik voted on patch set 2 CR +1 V +1 10/22/26, 16:27
-
Matthias Vogel voted on patch set 2 CR +1 V +1 10/22/26, 16:34
-
Martin Adler commented on patch set 2 CR +1 10/22/26, 16:34
Well done, Myrna! -
Oli Bartsch voted on patch set 2 CR +2 V +2 10/22/26, 16:42
-
Oli Bartsch merged patch set 3 10/22/26, 16:42