Review main Merged

97018[BUGFIX] Keep additional parameters of record links

Benni Mack CR +2 V +2 Normal +220 −4 updated 11/09/26, 16:25

Commit message

Record links (t3://record) dropped every query parameter besides
"identifier" and "uid" when being converted back to a string, e.g.
when RTE content is saved. The "Additional link parameters" field of
the link browser therefore had no effect for record links, although
it works for page links, and cross-language links to records via
"&L=1" were impossible.

The RecordLinkHandler now additionally collects additional parameters
into "parameters" like the PageLinkHandler does, the link browser fills
its parameter field from them, and the frontend passes them on as
query parameters to the link of the record, so "L" or "_language"
select the target language. In that case, the availability of the
record is checked in the target language instead of the current one.

Existing record links with additional arguments, e.g. in link fields
or TypoScript, now render these arguments (plus cHash) in the
frontend, and an "L" argument switches the language of the link.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1318

  1. Benni Mack uploaded patch set 1 10/22/26, 16:27

  2. core-ci voted on patch set 1 V +1 10/22/26, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112148

  3. Benni Mack uploaded patch set 2 V +1 10/22/26, 16:51

  4. core-ci voted on patch set 2 V +1 10/22/26, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112157

  5. Benni Mack marked it ready for review 10/23/26, 12:16

  6. Benni Mack marked it work in progress 10/23/26, 12:16

  7. Benni Mack marked it ready for review 10/29/26, 11:52

  8. Benni Mack rebased onto patch set 3 V +1 10/29/26, 11:52

  9. core-ci voted on patch set 3 V +1 10/29/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112797

  10. Benni Mack rebased onto patch set 4 V +1 11/09/26, 13:01

  11. core-ci voted on patch set 4 V -1 11/09/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113678

  12. Oli Bartsch uploaded patch set 5 V -1 11/09/26, 14:04

  13. Oli Bartsch commented on patch set 5 11/09/26, 14:05

    RecordLinkHandler again returned all parsed link arguments as top-level keys, as before, and additionally added them as a 'parameters' query string. Existing consumers keep the old shape, which matters for the 14.3 backport. When a record link carries '_language' or 'L', DatabaseRecordLinkBuilder now checks the record against that target site language instead of the current one, unless the typolink configuration sets 'language' explicitly. An untranslated record is therefore no longer linked into a language it doesn't exist in.
  14. core-ci voted on patch set 5 V +1 11/09/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113696

  15. Oli Bartsch voted on patch set 5 CR +1 V +1 11/09/26, 14:49

  16. Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/09/26, 14:59

  17. Benni Mack voted on patch set 5 CR +2 V +2 11/09/26, 16:25

  18. Benni Mack merged patch set 6 11/09/26, 16:25