Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
97026[TASK] Reuse parent rootlines for page links
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/97026/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/97026/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Wolfgang Klinger +1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
97026 [TASK] Reuse parent rootlines for page links This change
- main 97023[TASK] Batch menu cache lifetime scheduling queries
Files 4
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php1+19 −1
- typo3/sysext/frontend/Tests/Functional/Typolink/Fixtures/RecordingRootlineFrontend.phpnew+31 −0
- typo3/sysext/frontend/Tests/Functional/Typolink/Fixtures/siteLookupPages.csvnew+15 −0
- typo3/sysext/frontend/Tests/Functional/Typolink/PageLinkBuilderTest.php+146 −0
Review log 45
-
Wouter Wolters uploaded patch set 1 10/22/26, 18:01
-
Wouter Wolters uploaded patch set 2 10/22/26, 18:40
-
Wouter Wolters wrote 10/22/26, 18:40
Unset private -
core-ci voted on patch set 2 V +1 10/22/26, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112168
-
Wolfgang Klinger commented on patch set 2 CR +1 10/23/26, 09:41
PageLinkBuilder.php:166UnresolvedDo we need that condition? Custom doctypes could benefit too(?)