Review main Merged

97028[BUGFIX] Keep t3:// format of file links on import

Georg Ringer CR +2 V +2 Normal +164 −17 updated 11/09/26, 22:44

Commit message

Exported file links in rich text fields keep their t3:// notation
when they are imported again, for example t3://file?uid=2 instead
of file:2. Record links are already remapped within the link by the
parent change.

The typolink_tag soft reference parser now uses the link itself as
token value of a file link, as it does for record links, so the
import replaces only the uid within the link.

The linkvalidator stores these file links with the link as url now.
Its file linktype and the broken link check of the rich text editor
recognize both notations.

Exports created before this change still contain "file:<uid>" as
token value and are imported as before.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 79

  1. Georg Ringer uploaded patch set 1 10/22/26, 18:42

  2. Georg Ringer commented on patch set 1 10/22/26, 18:43

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 10/22/26, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112174

  4. Oli Bartsch uploaded patch set 2 V -1 11/09/26, 18:52

  5. core-ci voted on patch set 2 V +1 11/09/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113764

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/09/26, 21:21

  7. Benni Mack voted on patch set 2 CR +1 V +1 11/09/26, 22:02

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 11/09/26, 22:44

  9. Oli Bartsch merged patch set 3 11/09/26, 22:44