Review main Merged

97031[TASK] Await clicks in Playwright fixtures

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 10/23/26, 05:58

Commit message

The module and FormEngine fixtures, as well as the recycler spec,
installed a waiter for the next module load and then triggered the
click without awaiting it. A failing click therefore surfaced as an
unhandled rejection or as a timeout of the waiter, instead of the
actual error of the click.

The clicks are awaited now. The waiter is installed before the click
as before, so no load event can be missed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/22/26, 19:56

  2. Josua Vogel voted on patch set 1 CR +1 V +1 10/22/26, 19:58

  3. core-ci voted on patch set 1 V +1 10/22/26, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112181

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/22/26, 20:16

  5. Oliver Klee voted on patch set 1 V +1 10/22/26, 20:21

  6. Georg Ringer voted on patch set 1 CR +2 V +2 10/23/26, 05:33

  7. Georg Ringer merged patch set 2 10/23/26, 05:58