Review main Merged

97037[TASK] Strengthen bookmark creation tests

Wouter Wolters CR +2 V +2 Easy +22 −9 updated 10/23/26, 04:43

Commit message

The functional test for invalid bookmark arguments only checked that
creation did not throw. It could pass when malformed JSON was stored or
when valid JSON arguments were silently discarded.

Separate malformed JSON rejection from valid JSON persistence and
assert the return values and stored bookmark data.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Wouter Wolters uploaded patch set 1 10/22/26, 21:02

  2. core-ci voted on patch set 1 V +1 10/22/26, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112188

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/23/26, 04:43

  4. Benni Mack merged patch set 2 10/23/26, 04:43