97050[TASK] Add table semantics to the clipboard panel
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1012
-
Maike Kiebele uploaded patch set 1 10/23/26, 07:31
-
core-ci voted on patch set 1 V +1 10/23/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112231
-
Oli Bartsch commented on patch set 1 10/23/26, 08:48
clipboard-panel.ts:113Adding this here, makes `position: absolute` and `display: block`. Core elsewhere keeps the `thead` and hides only the text. Could you follow that pattern? Changing the display of table parts can lose table semantics in some engines, and I only checked Chromium, not Safari/VoiceOver.ClipboardController.php:94Usually, new label references should use the domain syntax, e.g. core.core:labels.clipboardElement. However, since the other lines still use LLL:EXT:, we might keep it for consistency here. -
Christian Rath-Ulrich commented on patch set 1 V +1 10/23/26, 19:25
clipboard-panel.ts:112ReplyI’ve tested the whole thing in NVDA and now everything is read aloud and accessible via the Tab key; compared to before, the multi-clipboard function is now usable. The complete redesign into collapsible and expandable elements containing lists is therefore no longer strictly necessary. At least from an accessibility perspective, we’re in the clear. -
Georg Ringer voted on patch set 1 CR +1 V +1 10/31/26, 12:33
-
Maike Kiebele uploaded patch set 2
CR +1V +111/05/26, 13:40 -
core-ci voted on patch set 2 V +1 11/05/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113411
-
Maike Kiebele commented on patch set 2 11/05/26, 14:34
clipboard-panel.ts:113ReplyDone -
Oli Bartsch commented on patch set 2 CR +1 V +1 11/06/26, 07:51
ClipboardController.php:94ReplyDone -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 09:14
-
Georg Ringer voted on patch set 2 CR +2 V +2 11/06/26, 09:25
-
Georg Ringer merged patch set 3 11/06/26, 09:25
clipboard-panel.ts:112