Review main Merged

97050[TASK] Add table semantics to the clipboard panel

Maike Kiebele CR +2 V +2 Easy +19 −8 updated 11/06/26, 09:25

Commit message

Label the clipboard table by the panel heading, add visually hidden
column headers and use the pad buttons and entry titles as row
headers. Screen readers now announce the entry and the column an
action belongs to.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Maike Kiebele uploaded patch set 1 10/23/26, 07:31

  2. core-ci voted on patch set 1 V +1 10/23/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112231

  3. Oli Bartsch commented on patch set 1 10/23/26, 08:48

    clipboard-panel.ts:112

    While this should resolve #108988, but that issue asks for a `<ul>`/`<ol>` announced as a list with an item count, and this patch keeps a table. A screen reader announces "table, N rows, 3 columns", where N also counts the header and pad rows. Please either get agreement from the reporter or the a11y team on Forge that a labelled table is fine and explain that in the commit body, or switch. Implementing the list (pads as items, current pad entries in a nested list) would IMO also work.

    clipboard-panel.ts:113

    Adding this here, makes `position: absolute` and `display: block`. Core elsewhere keeps the `thead` and hides only the text. Could you follow that pattern? Changing the display of table parts can lose table semantics in some engines, and I only checked Chromium, not Safari/VoiceOver.

    ClipboardController.php:94

    Usually, new label references should use the domain syntax, e.g. core.core:labels.clipboardElement. However, since the other lines still use LLL:EXT:, we might keep it for consistency here.
  4. Christian Rath-Ulrich commented on patch set 1 V +1 10/23/26, 19:25

    clipboard-panel.ts:112 Reply

    I’ve tested the whole thing in NVDA and now everything is read aloud and accessible via the Tab key; compared to before, the multi-clipboard function is now usable. The complete redesign into collapsible and expandable elements containing lists is therefore no longer strictly necessary. At least from an accessibility perspective, we’re in the clear.
  5. Georg Ringer voted on patch set 1 CR +1 V +1 10/31/26, 12:33

  6. Maike Kiebele uploaded patch set 2 CR +1 V +1 11/05/26, 13:40

  7. core-ci voted on patch set 2 V +1 11/05/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113411

  8. Maike Kiebele commented on patch set 2 11/05/26, 14:34

    clipboard-panel.ts:113 Reply

    Done
  9. Oli Bartsch commented on patch set 2 CR +1 V +1 11/06/26, 07:51

    ClipboardController.php:94 Reply

    Done
  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 09:14

  11. Georg Ringer voted on patch set 2 CR +2 V +2 11/06/26, 09:25

  12. Georg Ringer merged patch set 3 11/06/26, 09:25