Review 14.3 Merged

97051[BUGFIX] Do not copy a folder into its own subfolder

Georg Ringer CR +2 V +2 Normal +72 −0 updated 10/23/26, 07:57

Commit message

Copying a folder into one of its own subfolders created an endlessly
nested folder structure. The check that prevented this was dropped
when the conflict mode handling was added to copyFolder().

ResourceStorage::copyFolder() throws an InvalidTargetFolderException
again in this case, like moveFolder() does.

The file list now explains this case in its own message and log
entry, instead of reporting a name conflict in the target folder.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 45

  1. Georg Ringer uploaded patch set 1 10/23/26, 07:33

  2. Georg Ringer commented on patch set 1 10/23/26, 07:35

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/23/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112232

  4. Georg Ringer voted on patch set 1 CR +2 V +2 10/23/26, 07:57

  5. Georg Ringer merged patch set 2 10/23/26, 07:57