Review main Merged

97052[BUGFIX] Use target site when booting frontend for redirect link

Georg Ringer CR +2 V +2 Easy +18 −1 updated 10/28/26, 09:58

Commit message

RedirectService now sets the site resolved for the redirect target
on the request that is handed to PageInformationFactory. The direct
page id check therefore compares the rootline with the root page of
the target site instead of the root page of a NullSite.

Redirects from a host without site configuration to a page target
no longer fail with a PageInformationCreationFailedException when
the incoming request contains an "id" query parameter.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 10/23/26, 07:33

  2. Georg Ringer commented on patch set 1 10/23/26, 07:34

    This change is ready for review.
  3. Georg Ringer updated the commit message in patch set 2 10/23/26, 07:34

  4. core-ci voted on patch set 1 V -1 10/23/26, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112233

  5. core-ci voted on patch set 2 V -1 10/23/26, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112234

  6. Georg Ringer rebased onto patch set 3 V -1 10/23/26, 13:43

  7. core-ci voted on patch set 3 V +1 10/23/26, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112312

  8. Markus Klein voted on patch set 3 CR +1 10/24/26, 18:15

  9. Wouter Wolters voted on patch set 3 CR +1 V +1 10/24/26, 20:56

  10. Markus Klein voted on patch set 3 V +1 10/26/26, 21:24

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/27/26, 01:01

  12. Benni Mack voted on patch set 3 CR +2 V +2 10/28/26, 09:58

  13. Benni Mack merged patch set 4 10/28/26, 09:58