97053[BUGFIX] Use language 0 as default language of a site
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- André Buchmann +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2228
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 10/23/26, 07:40
-
core-ci voted on patch set 1 V +1 10/23/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112235
-
Georg Ringer voted on patch set 1 CR +1 V +1 10/23/26, 07:58
-
André Buchmann commented on patch set 1 10/23/26, 09:02
-
André Buchmann rebased onto patch set 2
CR +1V +110/23/26, 12:49 -
André Buchmann uploaded patch set 3 10/23/26, 13:01
-
André Buchmann commented on patch set 3 10/23/26, 13:02
Site.php:286ReplyDone -
core-ci voted on patch set 2 V +1 10/23/26, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112302
-
core-ci voted on patch set 3 V -1 10/23/26, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112303
-
André Buchmann uploaded patch set 4
V -110/23/26, 14:28 -
core-ci voted on patch set 4 V +1 10/23/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112321
-
Benni Mack voted on patch set 4 CR +1 V +1 10/23/26, 15:25
-
Eric Harrer voted on patch set 4 CR +1 V +1 10/27/26, 09:43
-
Josua Vogel voted on patch set 4 CR +1 V +1 10/28/26, 08:56
-
Benni Mack updated the commit message in patch set 5
CR +1V +110/28/26, 09:37 -
core-ci voted on patch set 5 V +1 10/28/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112693
-
Josua Vogel voted on patch set 5 CR +1 V +1 10/28/26, 09:56
-
Oli Bartsch commented on patch set 5 10/28/26, 10:19
Can we drop the exception and fall back to the first configured language instead? `return $this->languages[0] ?? reset($this->languages);` -
Benni Mack commented on patch set 5 10/28/26, 10:22
Reply
that was the original approach, then people don't know that TYPO3 does not support site configs without language=0 yet (e.g. page module will fail etc) -
Oli Bartsch commented on patch set 5 10/28/26, 10:29
Reply
Agree that we should make this visible. But currently such a site still renders in the frontend. The backend shows wrong columns, but I could not find a place that actually fails without language 0. With the exception, every frontend request of such a site breaks after an update. Can we split this? Use the fallback here as a plain bugfix, which we can backport to 14.3 and enforce language 0 in a follow-up on main only? Ideally that follow-up validates the site configuration when it is loaded or in the Sites module, so integrators get a clear message instead of an exception. -
Benni Mack commented on patch set 5 10/28/26, 15:57
Reply
fine by me. -
Oli Bartsch uploaded patch set 6
CR +1V +110/29/26, 22:06 -
Oli Bartsch commented on patch set 6 CR +1 V +1 10/29/26, 22:08
Reply
Done -
core-ci voted on patch set 6 V +1 10/29/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112812
-
Oli Bartsch commented on patch set 6 10/29/26, 22:38
Reply
Follow-ups: * tiles crash in the Sites overview for sites without language 0 https://review.typo3.org/c/Packages/TYPO3.CMS/+/97221 * enforcing language 0 in the Sites module https://review.typo3.org/c/Packages/TYPO3.CMS/+/97222 -
André Buchmann voted on patch set 6 CR +1 V +1 10/30/26, 06:10
-
Benni Mack voted on patch set 6 CR +2 V +2 10/30/26, 07:07
-
Benni Mack merged patch set 7 10/30/26, 07:07
Site.php:286