Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
97056[BUGFIX] Keep file metadata when moving or renaming files
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/97056/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/97056/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Wouter Wolters +1
-
Verified V +1 Needs a vote
- Oliver Klee +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Resource/Index/Indexer.php1+18 −7
- typo3/sysext/core/Classes/Resource/ResourceStorage.php1+4 −4
- typo3/sysext/core/Tests/Functional/Resource/Index/IndexerTest.php+19 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageRelocationMetaDataTest.phpnew+94 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+1 −1
Review log 57
-
Benni Mack uploaded patch set 1 10/23/26, 08:19
-
core-ci voted on patch set 1 V -1 10/23/26, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112244
-
Benni Mack rebased onto patch set 2
V -110/23/26, 12:19 -
core-ci voted on patch set 2 V +1 10/23/26, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112293
-
Wouter Wolters voted on patch set 2 CR +1 V +1 10/25/26, 09:48
-
Oliver Klee voted on patch set 2 V +1 10/25/26, 10:38
-
Oli Bartsch commented on patch set 2 10/25/26, 15:06
ResourceStorage.php:1963Unresolvedthe cross-storage branch of `moveFile()` now also goes throughh `updateIndexEntryOfRelocatedFile()`, so neither `autoExtractMetadata` nor `extractRequiredMetaData()` runs for the target storage. A file moved from a remote storage into a Local storage can keep 0/0 dimensions, while `copyFile()` extracts. Please either fill only the empty metadata keys when the storage changed, or state in the commit message that cross-storage moves no longer extract. Either way, we should cover this with a test.
Indexer.php:103Unresolved