Review main Merged

97058[TASK] Run the zero date tests on SQLite as well

Benjamin Franzke CR +2 V +2 Easy +13 −21 updated 10/23/26, 11:49

Commit message

DatetimeLegacyTest covers native DATE and DATETIME columns holding
"0000-00-00". They were excluded on SQLite only because they set
a MySQL sql_mode as init command, which SQLite rejects.
SQLite holds the zero date as text, so the tests now set that sql_mode
for the MySQL drivers only and run on SQLite too.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Benjamin Franzke uploaded patch set 1 10/23/26, 08:40

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/23/26, 09:13

  3. core-ci voted on patch set 1 V -1 10/23/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112249

  4. Benjamin Franzke rebased onto patch set 2 CR +1 V +1 10/23/26, 10:28

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 10/23/26, 10:30

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/23/26, 10:44

  7. core-ci voted on patch set 2 V +1 10/23/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112267

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/23/26, 11:49

  9. Benjamin Franzke merged patch set 3 10/23/26, 11:49