Review main Merged

97059[BUGFIX] Keep page path in section links if current URL has arguments

Benni Mack CR +2 V +2 Easy +31 −0 updated 11/10/26, 07:54

Commit message

A typolink to a section of the current page was rendered as a bare
"#fragment" whenever the link itself had no query parameters. If the
current request carried query or route arguments, such as the
"forgot password" view of felogin or the detail view of a route
enhancer, the browser stayed on that view instead of returning to
the plain page.

The fragment-only shortcut is now taken only if the current request
has no arguments as well.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 10/23/26, 08:55

  2. core-ci voted on patch set 1 V -1 10/23/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112250

  3. Benni Mack rebased onto patch set 2 V -1 10/23/26, 12:18

  4. core-ci voted on patch set 2 V +1 10/23/26, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112292

  5. Wouter Wolters voted on patch set 2 CR +1 V +1 10/25/26, 09:06

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 09:18

  7. Georg Ringer voted on patch set 2 CR +2 V +2 11/09/26, 21:47

  8. Georg Ringer merged patch set 3 11/10/26, 07:54