Review main Merged

97087[TASK] Use less SQL placeholders for file search

Markus Klein CR +2 V +2 Easy +18 −19 updated 10/24/26, 09:34

Commit message

The code created a new SQL placeholder for the search query for every
search word / search field combination (n x m).

Only create a placeholder for every search word.

Also remove a useless AND expression.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Markus Klein uploaded patch set 1 10/23/26, 18:46

  2. core-ci voted on patch set 1 V -1 10/23/26, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112358

  3. Markus Klein rebased onto patch set 2 V -1 10/23/26, 21:35

  4. core-ci voted on patch set 2 V +1 10/23/26, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112369

  5. Wouter Wolters voted on patch set 2 CR +1 V +1 10/24/26, 07:10

  6. Markus Klein rebased onto patch set 3 CR +1 V +1 10/24/26, 08:59

  7. Markus Klein commented on patch set 3 10/24/26, 09:00

    @typo3@wouterwolters.nl Sorry, didn't realize you rebased already. Thx.
  8. core-ci voted on patch set 3 V +1 10/24/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112406

  9. Wouter Wolters voted on patch set 3 CR +1 V +1 10/24/26, 09:28

  10. Benni Mack voted on patch set 3 CR +2 V +2 10/24/26, 09:34

  11. Benni Mack merged patch set 4 10/24/26, 09:34