Review main Merged

97111[TASK] Restore frontend authentication test state

Wouter Wolters CR +2 V +2 Easy +2 −3 updated 11/11/26, 09:56

Commit message

Enable PHPUnit global backups so permanent-login configuration does
not leak between frontend authentication tests. Remove obsolete error
suppression around storing session data to keep error reporting intact.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1721

  1. Wouter Wolters uploaded patch set 1 10/24/26, 19:36

  2. core-ci voted on patch set 1 V +1 10/24/26, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112430

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/24/26, 19:51

  4. Wouter Wolters uploaded patch set 2 CR +1 V +1 10/25/26, 16:06

  5. core-ci voted on patch set 2 V +1 10/25/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112515

  6. Wouter Wolters wrote 10/26/26, 19:45

    Unset private
  7. Wouter Wolters marked it ready for review 10/26/26, 19:45

  8. Oliver Klee voted on patch set 2 CR +1 V +1 10/26/26, 21:03

  9. Oliver Klee voted on patch set 2 CR 0 10/26/26, 21:06

  10. Oliver Klee commented on patch set 2 10/26/26, 21:06

    FrontendUserAuthenticationTest.php:121

    Could we use `#[WithoutErrorHandler]` instead? https://docs.phpunit.de/en/13.4/error-handling.html#error-handling
  11. Wouter Wolters uploaded patch set 3 V +1 10/26/26, 21:19

  12. Wouter Wolters commented on patch set 3 10/26/26, 21:21

    FrontendUserAuthenticationTest.php:121 Reply

    TYPO3 explicitly forbids #[WithoutErrorHandler] in PHPStan configuration (Build/phpstan/phpstan.neon:16)
  13. core-ci voted on patch set 3 V +1 10/26/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112614

  14. Oli Bartsch updated the commit message in patch set 4 V +1 11/10/26, 22:41

  15. Oli Bartsch commented on patch set 4 CR +1 V +1 11/10/26, 22:42

    FrontendUserAuthenticationTest.php:121 Reply

    Done
  16. core-ci voted on patch set 4 V +1 11/10/26, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113993

  17. Josua Vogel voted on patch set 4 CR +1 V +1 11/11/26, 07:21

  18. Garvin Hicking voted on patch set 4 CR +1 V +1 11/11/26, 07:27

  19. Oliver Klee voted on patch set 4 CR +1 V +1 11/11/26, 08:40

  20. Oli Bartsch voted on patch set 4 CR +2 V +2 11/11/26, 09:56

  21. Oli Bartsch merged patch set 5 11/11/26, 09:56