97111[TASK] Restore frontend authentication test state
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Garvin Hicking +1
- Josua Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Garvin Hicking +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1721
-
Wouter Wolters uploaded patch set 1 10/24/26, 19:36
-
core-ci voted on patch set 1 V +1 10/24/26, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112430
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/24/26, 19:51
-
Wouter Wolters uploaded patch set 2
CR +1V +110/25/26, 16:06 -
core-ci voted on patch set 2 V +1 10/25/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112515
-
Wouter Wolters wrote 10/26/26, 19:45
Unset private -
Wouter Wolters marked it ready for review 10/26/26, 19:45
-
Oliver Klee voted on patch set 2 CR +1 V +1 10/26/26, 21:03
-
Oliver Klee voted on patch set 2 CR 0 10/26/26, 21:06
-
Oliver Klee commented on patch set 2 10/26/26, 21:06
FrontendUserAuthenticationTest.php:121Could we use `#[WithoutErrorHandler]` instead? https://docs.phpunit.de/en/13.4/error-handling.html#error-handling -
Wouter Wolters uploaded patch set 3
V +110/26/26, 21:19 -
Wouter Wolters commented on patch set 3 10/26/26, 21:21
FrontendUserAuthenticationTest.php:121ReplyTYPO3 explicitly forbids #[WithoutErrorHandler] in PHPStan configuration (Build/phpstan/phpstan.neon:16) -
core-ci voted on patch set 3 V +1 10/26/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112614
-
Oli Bartsch updated the commit message in patch set 4
V +111/10/26, 22:41 -
Oli Bartsch commented on patch set 4 CR +1 V +1 11/10/26, 22:42
FrontendUserAuthenticationTest.php:121ReplyDone -
core-ci voted on patch set 4 V +1 11/10/26, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113993
-
Josua Vogel voted on patch set 4 CR +1 V +1 11/11/26, 07:21
-
Garvin Hicking voted on patch set 4 CR +1 V +1 11/11/26, 07:27
-
Oliver Klee voted on patch set 4 CR +1 V +1 11/11/26, 08:40
-
Oli Bartsch voted on patch set 4 CR +2 V +2 11/11/26, 09:56
-
Oli Bartsch merged patch set 5 11/11/26, 09:56