Review main Merged

97114[BUGFIX] Keep translated mount point routes when matching

Oli Bartsch CR +2 V +2 Normal +71 −1 updated 10/25/26, 11:50

Commit message

When a URL does not match a slug exactly, for example because a
PageType suffix '/' is configured, the slug candidate provider returns
candidates for the requested language and for each fallback language.
For a mount point showing the content of the mounted page, every
candidate is the mounted page after the language overlay. All of them
keep the uid of the default language page and get the same MPvar.

PageRouter builds the route collection name from the page uid and the
MPvar. Both candidates therefore get the same route name, and the
default language route replaces the translated one. The matched route
then belongs to the default language and is rejected because a
translation exists, so the translated page returns a 404.

The route collection name now uses the localized uid if one is set.
Routes of different language records no longer replace each other, and
the requested language matches first.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/24/26, 20:53

  2. core-ci voted on patch set 1 V +1 10/24/26, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112442

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/25/26, 09:19

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/25/26, 11:39

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/25/26, 11:50

  6. Oli Bartsch merged patch set 2 10/25/26, 11:50