97116[TASK] Preserve globals in request-related tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/adminpanel/Tests/Unit/Service/ProcessedImageCollectorTest.php+2 −6
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+2 −6
- typo3/sysext/indexed_search/Tests/Unit/FileContentParserTest.php+2 −6
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+2 −6
- typo3/sysext/redirects/Tests/Unit/Service/TemporaryPermissionMutationServiceTest.php+2 −6
Review log 1315
-
Wouter Wolters uploaded patch set 1 10/25/26, 09:08
-
Wouter Wolters updated the commit message in patch set 2 10/25/26, 18:14
-
Wouter Wolters marked it ready for review 10/25/26, 18:14
-
Wouter Wolters wrote 10/25/26, 18:14
Unset private -
core-ci voted on patch set 2 V +1 10/25/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112531
-
Oliver Klee commented on patch set 2 10/25/26, 18:58
I don't understand this. Can't we backup the globals using the corresponding PHPUnit attribute instead? -
Wouter Wolters wrote 10/26/26, 07:35
Set private -
Wouter Wolters uploaded patch set 3
V +110/26/26, 18:54 -
Wouter Wolters wrote 10/26/26, 18:55
Unset private -
Wouter Wolters commented on patch set 3 10/26/26, 18:55
Reply
Done -
Oliver Klee voted on patch set 3 CR +1 10/26/26, 18:57
-
core-ci voted on patch set 3 V +1 10/26/26, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112602
-
Oliver Klee voted on patch set 3 V +1 10/26/26, 19:11
-
Benni Mack voted on patch set 3 CR +2 V +2 10/28/26, 08:12
-
Benni Mack merged patch set 4 10/28/26, 08:12