Review main Merged

97116[TASK] Preserve globals in request-related tests

Wouter Wolters CR +2 V +2 Easy +10 −30 updated 10/28/26, 08:12

Commit message

Enable PHPUnit global backups for tests that modify the request or
backend user. Restore the incoming state after each test instead of
unsetting globals that may have existed before the test ran.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1315

  1. Wouter Wolters uploaded patch set 1 10/25/26, 09:08

  2. Wouter Wolters updated the commit message in patch set 2 10/25/26, 18:14

  3. Wouter Wolters marked it ready for review 10/25/26, 18:14

  4. Wouter Wolters wrote 10/25/26, 18:14

    Unset private
  5. core-ci voted on patch set 2 V +1 10/25/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112531

  6. Oliver Klee commented on patch set 2 10/25/26, 18:58

    I don't understand this. Can't we backup the globals using the corresponding PHPUnit attribute instead?
  7. Wouter Wolters wrote 10/26/26, 07:35

    Set private
  8. Wouter Wolters uploaded patch set 3 V +1 10/26/26, 18:54

  9. Wouter Wolters wrote 10/26/26, 18:55

    Unset private
  10. Wouter Wolters commented on patch set 3 10/26/26, 18:55

    Reply

    Done
  11. Oliver Klee voted on patch set 3 CR +1 10/26/26, 18:57

  12. core-ci voted on patch set 3 V +1 10/26/26, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112602

  13. Oliver Klee voted on patch set 3 V +1 10/26/26, 19:11

  14. Benni Mack voted on patch set 3 CR +2 V +2 10/28/26, 08:12

  15. Benni Mack merged patch set 4 10/28/26, 08:12