Review main Merged

97121[TASK] Restore globals after locking tests

Wouter Wolters CR +2 V +2 Easy +6 −25 updated 10/30/26, 22:59

Commit message

Use PHPUnit's BackupGlobals attribute in the file, semaphore and
factory locking tests to restore global state after each test.
Remove the manual configuration backup and priority cleanup so
previously absent configuration keys remain absent.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 89

  1. Wouter Wolters uploaded patch set 1 10/25/26, 09:08

  2. Wouter Wolters uploaded patch set 2 10/25/26, 09:18

  3. Wouter Wolters uploaded patch set 3 10/30/26, 22:19

  4. Wouter Wolters updated the commit message in patch set 4 10/30/26, 22:41

  5. Wouter Wolters marked it ready for review 10/30/26, 22:41

  6. Wouter Wolters wrote 10/30/26, 22:41

    Unset private
  7. core-ci voted on patch set 4 V +1 10/30/26, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112925

  8. Benni Mack voted on patch set 4 CR +2 V +2 10/30/26, 22:59

  9. Benni Mack merged patch set 5 10/30/26, 22:59