Review main Merged

97123[TASK] Clean up GeneralUtility test state

Wouter Wolters CR +2 V +2 Normal +23 −31 updated 10/25/26, 18:18

Commit message

Restore umask even when a tested operation or assertion fails. Remove
the unused internet-connectivity helper and its obsolete skip
documentation from GeneralUtilityTest.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Wouter Wolters uploaded patch set 1 10/25/26, 09:08

  2. Wouter Wolters uploaded patch set 2 10/25/26, 16:06

  3. Wouter Wolters updated the commit message in patch set 3 10/25/26, 16:12

  4. Wouter Wolters marked it ready for review 10/25/26, 16:12

  5. Wouter Wolters wrote 10/25/26, 16:12

    Unset private
  6. core-ci voted on patch set 3 V +1 10/25/26, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112523

  7. core-ci voted on patch set 2 V +1 10/25/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112522

  8. Benni Mack voted on patch set 3 CR +2 V +2 10/25/26, 18:18

  9. Benni Mack merged patch set 4 10/25/26, 18:18